Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

решение #709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oleksashcherbakov
Copy link

No description provided.

Copy link

@Dimosphen1 Dimosphen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes were requested.

app/main.py Outdated
Comment on lines 21 to 24
if self.hidden is False:
self.hidden = True
else:
self.hidden = False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write this method in one line as mentioned in the checklist.

app/main.py Outdated
Comment on lines 33 to 35
for i in range(len(Animal.alive)):
if herbivore == Animal.alive[i]:
Animal.alive.pop(i)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the .remove list method instead of the for loop here.

@oleksashcherbakov
Copy link
Author

поправил

Copy link

@pavlejviki pavlejviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants